Re: [PATCH] lib: objagg: Replace zero-length arrays with flexible-array member

From
David Miller <davem@davemloft.net>
Date
2020-02-17 02:33:17
Also in
lkml
Reply to
Gustavo A. R. Silva, 2020-02-11
From: "Gustavo A. R. Silva" <redacted>
Date: Tue, 11 Feb 2020 14:53:56 -0600
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <redacted>
Applied to net-next.
Thread (3 messages) 3 messages, 3 authors, last reply 2020-02-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help