Re: [PATCH] net: batman-adv: Use built-in RCU list checking
From: Sven Eckelmann <sven@narfation.org>
Date: 2020-02-16 16:17:52
Also in:
batman, linux-kernel-mentees, lkml
On Sunday, 16 February 2020 16:52:44 CET Madhuparna Bhowmik wrote: [...]
quoted
I understand this part. I was asking how you've identified them. Did you use any tool for that? coccinelle, sparse, ...Not really, I did it manually by inspecting each occurence.
In that case, I don't understand why you didn't convert the occurrences from hlist_for_each_entry_rcu to hlist_for_each_entry [1]. Because a manual inspection should have noticed that there will always be the lock around these ones. KInd regards, Sven [1] https://www.kernel.org/doc/html/v5.6-rc1/RCU/whatisRCU.html#analogy-with-reader-writer-locking
Attachments
- signature.asc [application/pgp-signature] 833 bytes