Thread (1 message) 1 message, 1 author, 2020-02-14
STALE2374d

[PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast()

From: Jules Irenge <hidden>
Date: 2020-02-14 20:49:13
Also in: lkml
Subsystem: networking [general], the rest, tipc network layer · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds, Jon Maloy, Tung Quang Nguyen

Sparse reports a warning at tipc_node_write_unlock_fast()

warning: context imbalance in tipc_node_write_unlock_fast
	 - unexpected unlock

The root cause is the missing annotation at tipc_node_write_unlock_fast()
Add the missing __releases(&n->lock) annotation

Signed-off-by: Jules Irenge <redacted>
---
 net/tipc/node.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/tipc/node.c b/net/tipc/node.c
index d8401789fa23..cc656b2205db 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -367,6 +367,7 @@ static void tipc_node_write_lock(struct tipc_node *n) __acquires(&n->lock)
 }
 
 static void tipc_node_write_unlock_fast(struct tipc_node *n)
+	__releases(&n->lock)
 {
 	write_unlock_bh(&n->lock);
 }
-- 
2.24.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help