From: Vladimir Oltean <olteanv@gmail.com>
Date: Mon, 24 Feb 2020 15:08:26 +0200

+static void vcap_key_set(struct vcap_data *data,
+			 enum vcap_is2_half_key_field field,
+			 u32 value, u32 mask)
+{
+	struct ocelot *ocelot = data->ocelot;
+	u32 offset = ocelot->vcap_is2_keys[field].offset;
+	u32 length = ocelot->vcap_is2_keys[field].length;

I know it is a pain in dependency chains of variables like this, but
please use reverse christmas tree ordering.

And likewise for the rest of your submission.

Thank you.