Thread (7 messages) flat view 7 messages, 2 authors, 2020-02-26

Re: [Patch nf] netfilter: xt_hashlimit: unregister proc file before releasing mutex

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2020-02-18 21:35:29
Also in: netfilter-devel

On Wed, Feb 12, 2020 at 10:53:52PM -0800, Cong Wang wrote:
Before releasing the global mutex, we only unlink the hashtable
from the hash list, its proc file is still not unregistered at
this point. So syzbot could trigger a race condition where a
parallel htable_create() could register the same file immediately
after the mutex is released.

Move htable_remove_proc_entry() back to mutex protection to
fix this. And, fold htable_destroy() into htable_put() to make
the code slightly easier to understand.
Probably revert previous one?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help