Thread (12 messages) flat view 12 messages, 2 authors, 2020-02-14

Re: [PATCH v2 net 3/3] wireguard: send: account for mtu=0 devices

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: 2020-02-14 18:15:55

On Fri, Feb 14, 2020 at 6:56 PM Eric Dumazet [off-list ref] wrote:
Oh dear, can you describe what do you expect of a wireguard device with mtu == 0 or mtu == 1

Why simply not allowing silly configurations, instead of convoluted tests in fast path ?

We are speaking of tunnels adding quite a lot of headers, so we better not try to make them
work on networks with tiny mtu. Just say no to syzbot.
The idea was that wireguard might still be useful for the persistent
keepalive stuff. This branch becomes very cold very fast, so I don't
think it makes a difference performance wise, but if you feel strongly
about it, I can get rid of it and set a non-zero min_mtu that's the
smallest thing wireguard's xmit semantics will accept. It sounds like
you'd prefer that?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help