Re: [PATCH v2 net 1/5] icmp: introduce helper for NAT'd source address in network device context

From
Jason A. Donenfeld <Jason@zx2c4.com>
Date
2020-02-11 09:59:52
Reply to
Florian Westphal, 2020-02-10
On Mon, Feb 10, 2020 at 11:33 PM Florian Westphal [off-list ref] wrote:
I think this is a bit too conservative, f.e. i don't see how
ndo-called skbs could be shared (tx path needs to be able to change skb
list pointers)?
Are you *sure* about that? Dave - do you know?

I'm asking with *asterisks* because I see a few drivers in tree that
do call skb_share_check from their ndo_start_xmit function. If this
makes no sense and isn't needed, then I'll send a cleanup series for
these. And, I'll remove it from icmp_ndo_send for v3, replacing it
with a `if (WARN_ON(skb_shared(skb_in))) return;`.

Thanks,
Jason
Thread (27 messages) 27 messages, 3 authors, last reply 2020-02-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help