On 2/3/2020 3:50 AM, Jiri Pirko wrote:

Thu, Jan 30, 2020 at 11:58:58PM CET, jacob.e.keller@intel.com wrote:

quoted

Add a new devlink command, DEVLINK_CMD_REGION_TAKE_SNAPSHOT. This

Hmm, the shapshot is now removed by user calling:

$ devlink region del DEV/REGION snapshot SNAPSHOT_ID
That is using DEVLINK_CMD_REGION_DEL netlink command calling
devlink_nl_cmd_region_del()

I think the creation should be symmetric. Something like:
$ devlink region add DEV/REGION snapshot SNAPSHOT_ID
SNAPSHOT_ID is either exact number or "any" if user does not care.
The benefit of using user-passed ID value is that you can use this
easily in scripts.

The existing unused netlink command DEVLINK_CMD_REGION_NEW would be used
for this.

Sure, this makes some sense. It will likely require refactoring the
snapshot id creation to handle the fact that users can choose a snapshot
id themselves.

This approach sounds like a more sound design, making the commands
symmetric and enabling easier usage from scripts.

Thanks,
Jake

quoted

    # Dump a snapshot:
    $ devlink region dump pci/0000:00:05.0/fw-health snapshot 1

[...]