On Sun, 2 Feb 2020 10:45:27 -0700, David Ahern wrote:

On 2/1/20 10:08 AM, Jakub Kicinski wrote:

quoted

If EGRESS is only for XDP frames we could try to hide the handling in
the core (with slight changes to XDP_TX handling in the drivers),  

It is not. I have said multiple times it is to work on ALL packets that
hit the xmit function, both skbs and xdp_frames.

Okay, I should have said "was to be", I guess?

 If EGRESS _was_to_be_ only for XDP frames we could try to hide the
 handling in the core (with slight changes to XDP_TX handling in the
 drivers), making drivers smaller and XDP feature velocity higher.

I understand you'd like a hook for all packets, that is clear.
I'm just trying to highlight the cost and consequences.