Thread (7 messages) flat view 7 messages, 4 authors, 2020-03-17

RE: [PATCH bpf-next] xsk: update rings for load-acquire/store-release semantics

From: John Fastabend <john.fastabend@gmail.com>
Date: 2020-01-21 01:25:02
Also in: bpf

Björn Töpel wrote:
quoted hunk ↗ jump to hunk
From: Björn Töpel <redacted>

Currently, the AF_XDP rings uses fences for the kernel-side
produce/consume functions. By updating rings for
load-acquire/store-release semantics, the full barrier (smp_mb()) on
the consumer side can be replaced.

Signed-off-by: Björn Töpel <redacted>
---
 net/xdp/xsk_queue.h | 31 ++++++++++++++-----------------
 1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/net/xdp/xsk_queue.h b/net/xdp/xsk_queue.h
index bec2af11853a..2fff80576ee1 100644
--- a/net/xdp/xsk_queue.h
+++ b/net/xdp/xsk_queue.h
@@ -39,19 +39,18 @@ struct xsk_queue {
 	u64 invalid_descs;
 };
Should the xsk_cons_* libbpf routines also be updated then as well?
In general my understanding is the userspace and kernel should be
in sync?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help