Re: [PATCH bpf-next 4/4] bpftool: avoid const discard compilation warning

On Fri, Jan 17, 2020 at 7:55 AM Quentin Monnet
[off-list ref] wrote:

2020-01-16 22:08 UTC-0800 ~ Andrii Nakryiko [off-list ref]

quoted

Avoid compilation warning in bpftool when assigning disassembler_options by
casting explicitly to non-const pointer.

Fixes: 3ddeac6705ab ("tools: bpftool: use 4 context mode for the NFP disasm")
Signed-off-by: Andrii Nakryiko <redacted>
---
 tools/bpf/bpftool/jit_disasm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
index bfed711258ce..22ef85b0f86c 100644
--- a/tools/bpf/bpftool/jit_disasm.c
+++ b/tools/bpf/bpftool/jit_disasm.c

@@ -119,7 +119,7 @@ void disasm_print_insn(unsigned char *image, ssize_t len, int opcodes,
      info.arch = bfd_get_arch(bfdf);
      info.mach = bfd_get_mach(bfdf);
      if (disassembler_options)
-             info.disassembler_options = disassembler_options;
+             info.disassembler_options = (char *)disassembler_options;
      info.buffer = image;
      info.buffer_length = len;

Thanks Andrii,

This fix has been proposed and discussed before:
https://lore.kernel.org/bpf/20190328141652.wssqboyekxmp6tkw@yubo-2/t/#u (local)

I still believe that we should not add the cast.

Oh, ok, didn't know that. Seems like Alexei dropped it already.

Best regards,
Quentin