Thread (3 messages) flat view 3 messages, 3 authors, 2020-01-10

Re: [PATCH bpf-next] libbpf: poison kernel-only integer types

From: Alexei Starovoitov <hidden>
Date: 2020-01-10 18:39:27
Also in: bpf

On Fri, Jan 10, 2020 at 10:19 AM Andrii Nakryiko [off-list ref] wrote:
It's been a recurring issue with types like u32 slipping into libbpf source
code accidentally. This is not detected during builds inside kernel source
tree, but becomes a compilation error in libbpf's Github repo. Libbpf is
supposed to use only __{s,u}{8,16,32,64} typedefs, so poison {s,u}{8,16,32,64}
explicitly in every .c file. Doing that in a bit more centralized way, e.g.,
inside libbpf_internal.h breaks selftests, which are both using kernel u32 and
libbpf_internal.h.

This patch also fixes a new u32 occurence in libbpf.c, added recently.

Fixes: 590a00888250 ("bpf: libbpf: Add STRUCT_OPS support")
Signed-off-by: Andrii Nakryiko <redacted>
Applied. Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help