Thread (4 messages) 4 messages, 4 authors, 2020-01-26

Re: [PATCH][next] iwlegacy: ensure loop counter addr does not wrap and cause an infinite loop

From: Kalle Valo <hidden>
Date: 2020-01-26 15:52:13
Also in: kernel-janitors, linux-wireless, lkml

Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

The loop counter addr is a u16 where as the upper limit of the loop
is an int. In the unlikely event that the il->cfg->eeprom_size is
greater than 64K then we end up with an infinite loop since addr will
wrap around an never reach upper loop limit. Fix this by making addr
an int.

Addresses-Coverity: ("Infinite loop")
Fixes: be663ab67077 ("iwlwifi: split the drivers for agn and legacy devices 3945/4965")
Signed-off-by: Colin Ian King <redacted>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Patch applied to wireless-drivers-next.git, thanks.

c2f9a4e4a5ab iwlegacy: ensure loop counter addr does not wrap and cause an infinite loop

-- 
https://patchwork.kernel.org/patch/11351769/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help