Thread (3 messages) 3 messages, 3 authors, 2020-01-22

Re: [PATCH v2] bpf: btf: Always output invariant hit in pahole DWARF to BTF transform

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2020-01-22 17:24:05
Also in: bpf, lkml

On 1/22/20 1:01 AM, Chris Down wrote:
When trying to compile with CONFIG_DEBUG_INFO_BTF enabled, I got this
error:

     % make -s
     Failed to generate BTF for vmlinux
     Try to disable CONFIG_DEBUG_INFO_BTF
     make[3]: *** [vmlinux] Error 1

Compiling again without -s shows the true error (that pahole is
missing), but since this is fatal, we should show the error
unconditionally on stderr as well, not silence it using the `info`
function. With this patch:

     % make -s
     BTF: .tmp_vmlinux.btf: pahole (pahole) is not available
     Failed to generate BTF for vmlinux
     Try to disable CONFIG_DEBUG_INFO_BTF
     make[3]: *** [vmlinux] Error 1

Signed-off-by: Chris Down <chris@chrisdown.name>
Cc: Stanislav Fomichev <redacted>
Cc: Andrii Nakryiko <redacted>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: bpf@vger.kernel.org
Cc: kernel-team@fb.com
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help