Thread (5 messages) 5 messages, 2 authors, 2020-01-21

Re: [PATCH] bpf: btf: Always output invariant hit in pahole DWARF to BTF transform

From: Chris Down <chris@chrisdown.name>
Date: 2020-01-21 20:29:21
Also in: bpf, lkml

Andrii Nakryiko writes:
quoted
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -108,13 +108,15 @@ gen_btf()
        local bin_arch

        if ! [ -x "$(command -v ${PAHOLE})" ]; then
-               info "BTF" "${1}: pahole (${PAHOLE}) is not available"
+               printf 'BTF: %s: pahole (%s) is not available\n' \
+                       "${1}" "${PAHOLE}" >&2
any reason not to use echo instead of printf? would be more minimal change
I generally avoid using echo because it has a bunch of portability gotchas 
which printf mostly doesn't have. If you'd prefer echo, that's fine though, 
just let me know and I can send v2.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help