Re: [PATCH -next] drivers: net: declance: fix comparing pointer to 0

From
Chen Zhou <hidden>
Date
2020-01-21 08:54:25
Also in
lkml
Reply to
Sergei Shtylyov, 2020-01-21
Hi Sergei,

On 2020/1/21 16:39, Sergei Shtylyov wrote:
Hello!

On 21.01.2020 4:35, Chen Zhou wrote:
quoted
Fixes coccicheck warning:

./drivers/net/ethernet/amd/declance.c:611:14-15:
    WARNING comparing pointer to 0

Compare pointer-typed values to NULL rather than 0.
   I don't see NULL in the patch -- you used ! instead.
Yeah, i used ! here.

Thanks,
Chen Zhou
quoted
Signed-off-by: Chen Zhou <redacted>
---
  drivers/net/ethernet/amd/declance.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/declance.c b/drivers/net/ethernet/amd/declance.c
index 6592a2d..7282ce5 100644
--- a/drivers/net/ethernet/amd/declance.c
+++ b/drivers/net/ethernet/amd/declance.c
@@ -608,7 +608,7 @@ static int lance_rx(struct net_device *dev)
              len = (*rds_ptr(rd, mblength, lp->type) & 0xfff) - 4;
              skb = netdev_alloc_skb(dev, len + 2);
  -            if (skb == 0) {
+            if (!skb) {
                  dev->stats.rx_dropped++;
                  *rds_ptr(rd, mblength, lp->type) = 0;
                  *rds_ptr(rd, rmd1, lp->type) =
MBR, Sergei
  
Thread (5 messages) 5 messages, 2 authors, last reply 2020-01-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help