Re: [PATCH 3/5] vDPA: introduce vDPA bus
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2020-01-20 12:17:41
Also in:
kvm, lkml, virtualization
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2020-01-20 12:17:41
Also in:
kvm, lkml, virtualization
On Fri, Jan 17, 2020 at 01:54:42PM +0000, Jason Gunthorpe wrote:
quoted
1) "virtio" vs "vhost", I implemented matching method for this in mdev series, but it looks unnecessary for vDPA device driver to know about this. Anyway we can use sysfs driver bind/unbind to switch drivers 2) virtio device id and vendor id. I'm not sure we need this consider the two drivers so far (virtio/vhost) are all bus drivers.As we seem to be contemplating some dynamic creation of vdpa devices I think upon creation time it should be specified what mode they should run it and then all driver binding and autoloading should happen automatically. Telling the user to bind/unbind is a very poor experience.
Maybe but OTOH it's an existing interface. I think we can reasonably start with bind/unbind and then add ability to specify the mode later. bind/unbind come from core so they will be maintained anyway. -- MST