Re: [PATCH] rtlwifi: rtl8188ee: remove redundant assignment to variable cond
From: Pkshih <pkshih@realtek.com>
Date: 2020-01-15 01:47:07
Also in:
kernel-janitors, linux-wireless, lkml
On Tue, 2020-01-14 at 16:56 +0000, Colin King wrote:
From: Colin Ian King <redacted>
Variable cond is being assigned with a value that is never
read, it is assigned a new value later on. The assignment is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>Acked-by: Ping-Ke Shih <pkshih@realtek.com> Thank you!!
quoted hunk ↗ jump to hunk
--- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.cb/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c index 5ca900f97d66..d13983ec09ad 100644--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c@@ -264,7 +264,7 @@ static bool _rtl88e_check_condition(struct ieee80211_hw*hw, u32 _board = rtlefuse->board_type; /*need efuse define*/ u32 _interface = rtlhal->interface; u32 _platform = 0x08;/*SupportPlatform */ - u32 cond = condition; + u32 cond; if (condition == 0xCDCDCDCD) return true;