[PATCH 4/6] netfilter: flowtable: Fix missing flush hardware on table free

[PATCH 0/6] Netfilter fixes for net · Pablo Neira Ayuso <pablo@netfilter.org> · 2020-01-31
[PATCH 1/6] netfilter: ipset: fix suspicious RCU usage in find_set_and_id · Pablo Neira Ayuso <pablo@netfilter.org> · 2020-01-31
Re: [PATCH 1/6] netfilter: ipset: fix suspicious RCU usage in find_set_and_id · Jakub Kicinski <kuba@kernel.org> · 2020-02-01
Re: [PATCH 1/6] netfilter: ipset: fix suspicious RCU usage in find_set_and_id · Jakub Kicinski <kuba@kernel.org> · 2020-02-01
Re: [PATCH 1/6] netfilter: ipset: fix suspicious RCU usage in find_set_and_id · Jozsef Kadlecsik <hidden> · 2020-02-01
Re: [PATCH 1/6] netfilter: ipset: fix suspicious RCU usage in find_set_and_id · Jakub Kicinski <kuba@kernel.org> · 2020-02-02
[PATCH 2/6] netfilter: Use kvcalloc · Pablo Neira Ayuso <pablo@netfilter.org> · 2020-01-31
[PATCH 4/6] netfilter: flowtable: Fix missing flush hardware on table free · Pablo Neira Ayuso <pablo@netfilter.org> · 2020-01-31
[PATCH 5/6] netfilter: flowtable: Fix setting forgotten NF_FLOW_HW_DEAD flag · Pablo Neira Ayuso <pablo@netfilter.org> · 2020-01-31
[PATCH 6/6] netfilter: nf_flowtable: fix documentation · Pablo Neira Ayuso <pablo@netfilter.org> · 2020-01-31
[PATCH 3/6] netfilter: flowtable: Fix hardware flush order on nf_flow_table_cleanup · Pablo Neira Ayuso <pablo@netfilter.org> · 2020-01-31
Re: [PATCH 0/6] Netfilter fixes for net · Jakub Kicinski <kuba@kernel.org> · 2020-02-01

Series revisions: v1 (2013-04-12) [diff vs current] → v1 (2013-09-17) [diff vs current] → v1 (2013-11-21) [diff vs current] → v1 (2014-02-19) [diff vs current] → v1 (2014-04-05) [diff vs current] → v1 (2014-05-09) [diff vs current] → v1 (2014-06-18) [diff vs current] → v1 (2014-08-11) [diff vs current] → v1 (2014-10-20) [diff vs current] → v1 (2014-10-27) [diff vs current] → v1 (2015-03-22) [diff vs current] → v1 (2015-05-16) [diff vs current] → v1 (2015-08-10) [diff vs current] → v1 (2015-09-18) [diff vs current] → v1 (2015-11-11) [diff vs current] → v1 (2016-01-20) [diff vs current] → v1 (2016-02-16) [diff vs current] → v1 (2016-06-01) [diff vs current] → v1 (2016-06-17) [diff vs current] → v1 (2016-08-10) [diff vs current] → v1 (2016-08-10) [diff vs current] → v1 (2016-08-30) [diff vs current] → v1 (2016-09-13) [diff vs current] → v1 (2016-10-21) [diff vs current] → v1 (2016-11-10) [diff vs current] → v1 (2016-11-30) [diff vs current] → v1 (2017-01-05) [diff vs current] → v1 (2017-02-23) [diff vs current] → v1 (2017-02-27) [diff vs current] → v1 (2017-03-15) [diff vs current] → v1 (2017-03-29) [diff vs current] → v1 (2017-04-14) [diff vs current] → v1 (2017-07-18) [diff vs current] → v1 (2017-08-24) [diff vs current] → v1 (2017-12-13) [diff vs current] → v1 (2018-02-01) [diff vs current] → v1 (2018-02-20) [diff vs current] → v1 (2018-03-12) [diff vs current] → v1 (2018-03-24) [diff vs current] → v1 (2018-06-13) [diff vs current] → v1 (2018-06-27) [diff vs current] → v1 (2018-07-09) [diff vs current] → v1 (2018-07-24) [diff vs current] → v1 (2018-10-02) [diff vs current] → v1 (2018-11-06) [diff vs current] → v1 (2018-11-28) [diff vs current] → v1 (2018-12-13) [diff vs current] → v1 (2018-12-29) [diff vs current] → v1 (2019-01-14) [diff vs current] → v1 (2019-02-05) [diff vs current] → v1 (2019-03-11) [diff vs current] → v1 (2019-03-21) [diff vs current] → v1 (2019-05-13) [diff vs current] → v1 (2019-07-19) [diff vs current] → v1 (2019-07-31) [diff vs current] → v1 (2019-08-14) [diff vs current] → v1 (2019-08-30) [diff vs current] → v1 (2019-09-04) [diff vs current] → v1 (2019-09-25) [diff vs current] → v1 (2019-11-06) [diff vs current] → v1 (2019-12-09) [diff vs current] → v1 (2019-12-26) [diff vs current] → v1 (2020-01-08) [diff vs current] → v1 (2020-01-25) [diff vs current] → v1 (2020-01-31) → v1 (2020-02-18) [diff vs current] → v1 (2020-02-26) [diff vs current] → v1 (2020-03-06) [diff vs current] → v1 (2020-04-07) [diff vs current] → v1 (2020-05-14) [diff vs current] → v1 (2020-05-25) [diff vs current] → v1 (2020-06-14) [diff vs current] → v1 (2020-06-25) [diff vs current] → v1 (2020-08-04) [diff vs current] → v1 (2020-08-15) [diff vs current] → v1 (2020-08-24) [diff vs current] → v1 (2020-08-31) [diff vs current] → v1 (2020-10-07) [diff vs current] → v1 (2020-10-13) [diff vs current] → v1 (2020-10-22) [diff vs current] → v1 (2020-10-31) [diff vs current] → v1 (2020-11-21) [diff vs current] → v1 (2020-12-18) [diff vs current] → v1 (2021-03-06) [diff vs current] → v1 (2021-03-19) [diff vs current] → v1 (2021-04-12) [diff vs current] → v1 (2021-05-07) [diff vs current] → v1 (2021-06-22) [diff vs current] → v1 (2021-07-07) [diff vs current] → v1 (2021-07-23) [diff vs current] → v1 (2021-08-06) [diff vs current] → v2 (2021-08-06) [diff vs current] → v1 (2021-09-03) [diff vs current] → v1 (2021-09-29) [diff vs current] → v1 (2021-11-18) [diff vs current] → v1 (2021-12-09) [diff vs current] → v1 (2022-01-06) [diff vs current] → v1 (2022-01-20) [diff vs current] → v1 (2022-01-27) [diff vs current] → v1 (2022-02-04) [diff vs current] → v1 (2022-02-10) [diff vs current] → v1 (2022-02-21) [diff vs current] → v2 (2022-02-22) [diff vs current] → v1 (2022-03-01) [diff vs current] → v1 (2022-05-18) [diff vs current] → v1 (2022-05-27) [diff vs current] → v1 (2022-05-31) [diff vs current] → v1 (2022-06-06) [diff vs current] → v1 (2022-06-21) [diff vs current] → v1 (2022-08-09) [diff vs current] → v1 (2022-08-24) [diff vs current] → v1 (2022-11-30) [diff vs current] → v1 (2023-01-02) [diff vs current] → v1 (2023-03-09) [diff vs current] → v1 (2023-04-18) [diff vs current] → v1 (2023-06-06) [diff vs current] → v1 (2023-06-27) [diff vs current] → v1 (2023-07-05) [diff vs current] → v1 (2023-08-10) [diff vs current] → v1 (2023-08-30) [diff vs current] → v1 (2023-09-13) [diff vs current] → v1 (2023-11-08) [diff vs current] → v1 (2023-11-15) [diff vs current] → v1 (2023-12-06) [diff vs current] → v1 (2024-01-17) [diff vs current] → v2 (2024-01-18) [diff vs current] → v1 (2024-01-24) [diff vs current] → v1 (2024-01-31) [diff vs current] → v1 (2024-02-07) [diff vs current] → v2 (2024-02-08) [diff vs current] → v1 (2024-02-22) [diff vs current] → v1 (2024-03-07) [diff vs current] → v1 (2024-03-28) [diff vs current] → v1 (2024-04-04) [diff vs current] → v1 (2024-04-11) [diff vs current] → v1 (2024-05-22) [diff vs current] → v2 (2024-05-23) [diff vs current] → v3 (2024-05-28) [diff vs current] → v1 (2024-06-19) [diff vs current] → v1 (2024-08-14) [diff vs current] → v1 (2024-09-24) [diff vs current] → v2 (2024-09-26) [diff vs current] → v1 (2024-10-02) [diff vs current] → v1 (2024-10-31) [diff vs current] → v1 (2024-11-28) [diff vs current] → v2 (2024-11-28) [diff vs current] → v1 (2024-12-05) [diff vs current] → v1 (2025-06-05) [diff vs current] → v1 (2025-07-17) [diff vs current] → v1 (2025-08-07) [diff vs current] → v2 (2026-03-25) [diff vs current] → v1 (2026-04-01) [diff vs current] → v2 (2026-04-28) [diff vs current] → v1 (2026-05-01) [diff vs current]
Activity: Last reply 2306 days ago

Lifecycle

2020-01-31 19:24 Posted Pablo Neira Ayuso <pablo@netfilter.org>

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2020-01-31 19:24:42
Also in: netfilter-devel
Subsystem: netfilter, networking [general], the rest · Maintainers: Pablo Neira Ayuso, Florian Westphal, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

From: Paul Blakey <redacted>

If entries exist when freeing a hardware offload enabled table,
we queue work for hardware while running the gc iteration.

Execute it (flush) after queueing.

Fixes: c29f74e0df7a ("netfilter: nf_flow_table: hardware offload support")
Signed-off-by: Paul Blakey <redacted>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/nf_flow_table_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netfilter/nf_flow_table_core.c b/net/netfilter/nf_flow_table_core.c
index 14a069c72bb2..8af28e10b4e6 100644
--- a/net/netfilter/nf_flow_table_core.c
+++ b/net/netfilter/nf_flow_table_core.c

@@ -553,6 +553,7 @@ void nf_flow_table_free(struct nf_flowtable *flow_table)
 	cancel_delayed_work_sync(&flow_table->gc_work);
 	nf_flow_table_iterate(flow_table, nf_flow_table_do_cleanup, NULL);
 	nf_flow_table_iterate(flow_table, nf_flow_offload_gc_step, flow_table);
+	nf_flow_table_offload_flush(flow_table);
 	rhashtable_destroy(&flow_table->rhashtable);
 }
 EXPORT_SYMBOL_GPL(nf_flow_table_free);

-- 
2.11.0

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help