Thread (11 messages) 11 messages, 3 authors, 2020-01-31

Re: [PATCH net v2 2/3] taprio: Allow users not to specify "flags" when changing schedules

From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: 2020-01-29 18:12:05

David Miller [off-list ref] writes:
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: Tue, 28 Jan 2020 15:52:26 -0800
quoted
When any offload mode is enabled, users had to specify the
"flags" parameter when adding a new "admin" schedule.

This fix allows that parameter to be omitted when adding a new
schedule.

This will make that we have one source of truth for 'flags'.

Fixes: 4cfd5779bd6e ("taprio: Add support for txtime-assist mode")
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>
This will visibly change behavior for a feature in a released
kernel (v5.3 and later) and it means that newer tools will do
things that don't work in older kernels.

I think your opportunity to adjust these semantics, has therefore,
long passed.
Understood. Another lesson learned.

I'll need to send another version then. This semantic change have
creeped up to the "rcu stall" fix.


Cheers,
--
Vinicius
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help