Re: [PATCH] brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362
From: Kalle Valo <hidden>
Date: 2020-01-26 15:41:42
Also in:
linux-wireless
Jean-Philippe Brucker [off-list ref] wrote:
Commit 262f2b53f679 ("brcmfmac: call brcmf_attach() just before calling
brcmf_bus_started()") changed the initialization order of the brcmfmac
SDIO driver. Unfortunately since brcmf_sdiod_intr_register() is now
called before the sdiodev->bus_if initialization, it reads the wrong
chip ID and fails to initialize the GPIO on brcm43362. Thus the chip
cannot send interrupts and fails to probe:
[ 12.517023] brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
[ 12.531214] ieee80211 phy0: brcmf_bus_started: failed: -110
[ 12.536976] ieee80211 phy0: brcmf_attach: dongle is not responding: err=-110
[ 12.566467] brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed
Initialize the bus interface earlier to ensure that
brcmf_sdiod_intr_register() properly sets up the OOB interrupt.
BugLink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908438
Fixes: 262f2b53f679 ("brcmfmac: call brcmf_attach() just before calling brcmf_bus_started()")
Signed-off-by: Jean-Philippe Brucker <redacted>
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>Patch applied to wireless-drivers-next.git, thanks. 8c8e60fb86a9 brcmfmac: sdio: Fix OOB interrupt initialization on brcm43362 -- https://patchwork.kernel.org/patch/11310417/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches