Re: [PATCH net v1 2/3] taprio: Fix still allowing changing the flags during runtime
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: 2020-01-25 20:25:55
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: 2020-01-25 20:25:55
Hi, Vladimir Oltean [off-list ref] writes:
You can't quite do this, since it now breaks plain 'tc qdisc add' behavior. Can you initialize q->flags to -1 in taprio_init, just below q->clockid, and keep the "q->flags != -1" check here? You might also need to validate the taprio_flags to be a positive value.
Ugh, thanks for pointing this out. Will re-spin the series fixing this. Another lesson on not sending patches last thing on a friday. Cheers, -- Vinicius