Re: [PATCH net-next v4 05/10] pie: rearrange structure members and their initializations
From: David Miller <davem@davemloft.net>
Date: 2020-01-21 14:35:30
From: David Miller <davem@davemloft.net>
Date: 2020-01-21 14:35:30
From: gautamramk@gmail.com Date: Tue, 21 Jan 2020 19:42:44 +0530
From: "Mohit P. Tahiliani" <redacted> Rearrange the members of the structures such that they appear in order of their types. Also, change the order of their initializations to match the order in which they appear in the structures. This improves the code's readability and consistency. Signed-off-by: Mohit P. Tahiliani <redacted> Signed-off-by: Leslie Monis <redacted> Signed-off-by: Gautam Ramakrishnan <redacted>
What matters for structure member ordering is dense packing and grouping commonly-used-together elements for performance. "order of their types" are none of those things.