Re: [PATCH net-next 3/8] net: bridge: vlan: add rtm definitions and dump support

On 1/14/20 6:55 AM, Jakub Kicinski wrote:

On Mon, 13 Jan 2020 17:52:28 +0200, Nikolay Aleksandrov wrote:

quoted

+static int br_vlan_rtm_dump(struct sk_buff *skb, struct netlink_callback *cb)
+{
+	int idx = 0, err = 0, s_idx = cb->args[0];
+	struct net *net = sock_net(skb->sk);
+	struct br_vlan_msg *bvm;
+	struct net_device *dev;
+
+	if (cb->nlh->nlmsg_len < nlmsg_msg_size(sizeof(*bvm))) {

I wonder if it'd be useful to make this a strict != check? At least
when strict validation is on? Perhaps we'll one day want to extend 
the request?

+1. All new code should be using the strict checks.