Re: WARNING: bad unlock balance in sch_direct_xmit
From: Cong Wang <hidden>
Date: 2020-01-07 05:36:33
From: Cong Wang <hidden>
Date: 2020-01-07 05:36:33
Hi, Taehee On Sun, Jan 5, 2020 at 2:59 PM syzbot [off-list ref] wrote:
syzbot has bisected this bug to:
commit ab92d68fc22f9afab480153bd82a20f6e2533769
Author: Taehee Yoo [off-list ref]
Date: Mon Oct 21 18:47:51 2019 +0000
net: core: add generic lockdep keysWhy netdev_update_lockdep_key() is needed? It causes the bug here because the unregister and register are not atomic although under RTNL, fast path could still lock with one key and unlock with another key after the previous got unregistered. From my understand of lockdep here, as long as the device itself is not changed, it doesn't need to update those keys. Thanks.