Re: [PATCH V7 net-next 01/11] net: phy: Introduce helper functions for time stamping support.

On 12/20/19 10:15 AM, Richard Cochran wrote:

Some parts of the networking stack and at least one driver test fields
within the 'struct phy_device' in order to query time stamping
capabilities and to invoke time stamping methods.  This patch adds a
functional interface around the time stamping fields.  This will allow
insulating the callers from future changes to the details of the time
stamping implemenation.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Ideally we may even add locking annotations to make sure that there
there is no use after free in that the test is true, you de-reference
the PHY device and/or driver method, and boom. All callers appear to be
under RTNL right now.
-- 
Florian