Re: [PATCHv2] bpf: Emit audit messages upon successful prog load and unload

From
Jiri Olsa <hidden>
Date
2019-12-06 21:28:03
Also in
bpf
Reply to
Paul Moore, 2019-12-06
On Fri, Dec 06, 2019 at 04:11:13PM -0500, Paul Moore wrote:

SNIP
quoted
 #define IS_FD_ARRAY(map) ((map)->map_type == BPF_MAP_TYPE_PERF_EVENT_ARRAY || \
@@ -1306,6 +1307,36 @@ static int find_prog_type(enum bpf_prog_type type, struct bpf_prog *prog)
        return 0;
 }

+enum bpf_audit {
+       BPF_AUDIT_LOAD,
+       BPF_AUDIT_UNLOAD,
+       BPF_AUDIT_MAX,
+};
+
+static const char * const bpf_audit_str[BPF_AUDIT_MAX] = {
+       [BPF_AUDIT_LOAD]   = "LOAD",
+       [BPF_AUDIT_UNLOAD] = "UNLOAD",
+};
+
+static void bpf_audit_prog(const struct bpf_prog *prog, unsigned int op)
+{
+       struct audit_context *ctx = NULL;
+       struct audit_buffer *ab;
+
+       if (audit_enabled == AUDIT_OFF)
+               return;
+       if (WARN_ON_ONCE(op >= BPF_AUDIT_MAX))
+               return;
I feel bad saying this given the number of revisions we are at with
this patch, but since we aren't even at -rc1 yet (although it will be
here soon), I'm going to mention it anyway ;)

... if we move the "op >= BPF_AUDIT_MAX" above the audit_enabled check
we will catch problems sooner in development, which is a very good
thing as far as I'm concerned.
sure, np will post v3
Other than that, this looks good to me, and I see Steve has already
given the userspace portion a thumbs-up.  Have you started on the
audit-testsuite test for this yet?
yep, it's ready.. waiting for kernel change ;-)
https://github.com/olsajiri/audit-testsuite/commit/16888ea7f14fa0269feef623d2a96f15f9ea71c9

jirka
Thread (4 messages) 4 messages, 3 authors, last reply 2019-12-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help