Re: [PATCH] stmmac: debugfs entry name is not be changed when udev rename device name.
From: Randy Dunlap <hidden>
Date: 2019-12-31 02:22:41
Also in:
linux-arm-kernel, lkml
On 12/30/19 6:16 PM, Jiping Ma wrote:
On 12/31/2019 10:11 AM, Randy Dunlap wrote:quoted
Hi, On 12/30/19 6:03 PM, Jiping Ma wrote:quoted
Add one notifier for udev changes net device name. Signed-off-by: Jiping Ma <redacted> --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 38 ++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index b14f46a57154..c1c877bb4421 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c@@ -4038,6 +4038,40 @@ static int stmmac_dma_cap_show(struct seq_file *seq, void *v)} DEFINE_SHOW_ATTRIBUTE(stmmac_dma_cap); +/**Just use /* here since this is not a kernel-doc comment. /** is reserved for kernel-doc comments/notation.I use checkpatch.pl to check my patch, it show one warning, then I change * to **. I will change it back to *.
It should be more like: /* Use network device events to create/remove/rename * debugfs file entries. */
WARNING: networking block comments don't use an empty /* line, use /* Comment... #23: FILE: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4042: +/* + * Use network device events to create/remove/renamequoted
quoted
+ * Use network device events to create/remove/rename + * debugfs file entries + */ +static int stmmac_device_event(struct notifier_block *unused, + unsigned long event, void *ptr) +{
-- ~Randy Reported-by: Randy Dunlap <redacted>