Thread (36 messages) 36 messages, 4 authors, 2019-12-27

Re: [PATCH net-next v8 14/14] ethtool: provide link state with LINKSTATE_GET request

From: Michal Kubecek <hidden>
Date: 2019-12-27 12:48:05
Also in: lkml

On Mon, Dec 23, 2019 at 08:44:19PM -0800, Florian Fainelli wrote:

On 12/22/2019 3:46 PM, Michal Kubecek wrote:
quoted
Implement LINKSTATE_GET netlink request to get link state information.

At the moment, only link up flag as provided by ETHTOOL_GLINK ioctl command
is returned.

LINKSTATE_GET request can be used with NLM_F_DUMP (without device
identification) to request the information for all devices in current
network namespace providing the data.

Signed-off-by: Michal Kubecek <redacted>
---
[snip]
quoted
+Kernel response contents:
+
+  ====================================  ======  ==========================
+  ``ETHTOOL_A_LINKSTATE_HEADER``        nested  reply header
+  ``ETHTOOL_A_LINKSTATE_LINK``          u8      autonegotiation status
^ ==== Humm, auto-negotiation status may not be exactly accurate
especially with complex devices with SerDes/PHY/SFPs/what have you/.
Other than that, the code looks correct:
It seems I forgot to edit this cell text after copy&paste from
LINKMODES_GET above. Fixed in v9, thanks.

Michal
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help