Br,
Po Liu

-----Original Message-----
From: David Miller <davem@davemloft.net>
Sent: 2019年12月27日 7:10
To: Po Liu <redacted>
Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
vinicius.gomes@intel.com; Claudiu Manoil [off-list ref];
Vladimir Oltean [off-list ref]; Alexandru Marginean
[off-list ref]; Xiaoliang Yang
[off-list ref]; Roy Zang [off-list ref]; Mingkai Hu
[off-list ref]; Jerry Huang [off-list ref]; Leo Li
[off-list ref]; ivan.khoronzhuk@linaro.org
Subject: [EXT] Re: [net-next] enetc: add support time specific departure base on
the qos etf

Caution: EXT Email

From: Po Liu <redacted>
Date: Mon, 23 Dec 2019 03:42:39 +0000

quoted

- Transmit checksum offloads and time specific departure operation are
mutually exclusive.

I do not see anything which enforces this conflict.

It looks to me like if the user configures time specific departure, and TX SKBs will
be checksum offloaded, the time specific departure will simply not be performed.

If true, this behavior will be very surprising for the user.

Instead, the configuration operation that creates the conflict should throw and
error and fail.

I would fix it.

Thank you.