Re: [PATCH net-next] net: dsa: drop pointless static qualifier in ar9331_sw_mbus_init
From: Marek Behun <hidden>
Date: 2019-12-24 10:45:10
Also in:
kernel-janitors, lkml
Hi Mao, the commit title should be something of the form net: dsa: qca: ar9331: drop pointless static qualifier or net: dsa: ar9331: drop pointless static qualifier If it begins only with net: dsa: then it makes people think you are changing stuff in main dsa code. Marek On Tue, 24 Dec 2019 10:40:59 +0800 Mao Wenan [off-list ref] wrote:
quoted hunk ↗ jump to hunk
There is no need to have the 'T *v' variable static since new value always be assigned before use it. Signed-off-by: Mao Wenan <redacted> --- drivers/net/dsa/qca/ar9331.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index 0d1a7cd85fe8..da3bece75e21 100644 --- a/drivers/net/dsa/qca/ar9331.c +++ b/drivers/net/dsa/qca/ar9331.c@@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum) static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv) { struct device *dev = priv->dev; - static struct mii_bus *mbus; + struct mii_bus *mbus; struct device_node *np, *mnp; int ret;