Thread (9 messages) 9 messages, 3 authors, 2019-12-28

Re: [PATCH net-next 2/3] ptp: clockmatrix: Remove IDT references or replace with Renesas.

From: Vincent Cheng <hidden>
Date: 2019-12-18 14:45:19
Also in: linux-devicetree, lkml

On Wed, Dec 18, 2019 at 01:29:56AM EST, David Miller wrote:
From: vincent.cheng.xh@renesas.com
Date: Tue, 17 Dec 2019 00:03:07 -0500
quoted
From: Vincent Cheng <redacted>

Renesas Electronics Corporation completed acquisition of IDT in 2019.

This patch removes IDT references or replaces IDT with Renesas.
Renamed idt8a340_reg.h to clockmatrix_reg.h.
There were no functional changes.

Signed-off-by: Vincent Cheng <redacted>
Sorry, we don't do stuff like this.

The driver shall keep the reference to it's old vendor name, and
this is how we've handled similar situations in the past.
Sorry, was not aware.
And do you know the worst part about this?  You DID in fact
functionally change this driver:
quoted
-#define FW_FILENAME	"idtcm.bin"
+#define FW_FILENAME	"cm_tcs.bin"
Now everyone would have missing firmware.

So not only is this unacceptable on precedence grounds, and how we
always handle situations like this, it's functionally wrong and would
break things for users.

Please remove this patch and resubmit #1 and #3 as a series for
re-review.
What is the proper way to remove a patch submission?

Regards,
Vincent
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help