Thread (1 message) 1 message, 1 author, 2019-12-13

Re: [PATCH 1/2] net-next: stmmac: mediatek: add more suuport for RMII

From: Andrew Lunn <andrew@lunn.ch>
Date: 2019-12-13 20:37:27
Also in: linux-arm-kernel, linux-devicetree, linux-mediatek, lkml

The clock labeled as "rmii_internal" is needed only in RMII(when MAC provides
reference clock), and useless for RGMII/MII/RMII(when phy provides reference
clock).

So, add a boolean flag to indicate where the RMII reference clock is from, MAC
or PHY, if MAC, enable the "rmii_internal", or disable it.
and this clock already documented in dt-binding in PATCH 2/2.

For power saving, it should not be enabled in default, so can't add it to the
existing list of clocks directly.

Any advice for this special case?
O.K. Add the boolean, but also add the clock to the list of clocks in
DT. Don't hard code the clock name in the driver.

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help