Hi Andrew,

On Wed, 2019-12-11 at 00:20 +0800, Andrew Lunn wrote:

quoted

+Example 4:
+
+&eth {
+	gmac0: mac@0 {
+		compatible = "mediatek,eth-mac";
+		reg = <0>;
+		phy-mode = "2500base-x";
+
+		fixed-link {
+			speed = <1000>;
+			full-duplex;
+			pause;
+		};
+	};

2500Base-X, but fixed link speed 1000?

fixed-link speed should be 2500. I will update it.

quoted

+				port@6 {
+					reg = <6>;
+					label = "cpu";
+					ethernet = <&gmac0>;
+					phy-mode = "2500base-x";
+
+					fixed-link {
+						speed = <1000>;
+						full-duplex;
+						pause;
+					};

Same here!

I will update it or remove fixed-link block as the discussion in dts
thread.

     Andrew

regards Landen