Re: [PATCH v1] mt76: mt7615: Fix build with older compilers
From: Kalle Valo <hidden>
Date: 2019-12-02 09:25:08
Also in:
linux-wireless, lkml
Pablo Greco [off-list ref] writes:
quoted hunk
Some compilers (tested with 4.8.5 from CentOS 7) fail properly process FIELD_GET inside an inline function, which ends up in a BUILD_BUG_ON. Convert inline function to a macro. Fixes commit bf92e7685100 ("mt76: mt7615: add support for per-chain signal strength reporting") Reported in https://lkml.org/lkml/2019/9/21/146 Reported-by: kbuild test robot <redacted> Signed-off-by: Pablo Greco <redacted> --- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c index c77adc5d2552..77e395ca2c6a 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c@@ -13,10 +13,7 @@ #include "../dma.h" #include "mac.h" -static inline s8 to_rssi(u32 field, u32 rxv) -{ - return (FIELD_GET(field, rxv) - 220) / 2; -} +#define to_rssi(field, rxv) ((FIELD_GET(field, rxv) - 220) / 2)
What about u32_get_bits() instead of FIELD_GET(), would that work? I guess chances for that is slim, but it's always a shame to convert a function to a macro so we should try other methods first. Or even better if we could fix FIELD_GET() to work with older compilers. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches