Re: [PATCH net-next 2/3] net: dsa: sja1105: Use PTP core's dedicated kernel thread for RX timestamping

On Fri, 27 Dec 2019 at 07:28, kbuild test robot [off-list ref] wrote:

Hi Vladimir,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master v5.5-rc3 next-20191220]
[cannot apply to sparc-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Improvements-to-SJA1105-DSA-RX-timestamping/20191227-104228
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 0914d2bb11cc182039084ac3b961dc359b647468
config: sparc64-randconfig-a001-20191226 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=sparc64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <redacted>

All errors (new ones prefixed by >>):

   drivers/net/dsa/sja1105/sja1105_ptp.c: In function 'sja1105_change_rxtstamping':
   drivers/net/dsa/sja1105/sja1105_ptp.c:86:27: warning: unused variable 'ptp_data' [-Wunused-variable]
     struct sja1105_ptp_data *ptp_data = &priv->ptp_data;
                              ^~~~~~~~

Oops, this should have been part of 3/3 not 2/3...

   drivers/net/dsa/sja1105/sja1105_ptp.c: In function 'sja1105_ptp_clock_unregister':

quoted

quoted

drivers/net/dsa/sja1105/sja1105_ptp.c:654:2: error: implicit declaration of function 'ptp_cancel_worker_sync'; did you mean 'cancel_work_sync'? [-Werror=implicit-function-declaration]

And the attached .config.gz says that the error here is on the case
where CONFIG_PTP_1588_CLOCK=n. Ok.

     ptp_cancel_worker_sync(ptp_data->clock);
     ^~~~~~~~~~~~~~~~~~~~~~
     cancel_work_sync
   cc1: some warnings being treated as errors

vim +654 drivers/net/dsa/sja1105/sja1105_ptp.c

   645
   646  void sja1105_ptp_clock_unregister(struct dsa_switch *ds)
   647  {
   648          struct sja1105_private *priv = ds->priv;
   649          struct sja1105_ptp_data *ptp_data = &priv->ptp_data;
   650
   651          if (IS_ERR_OR_NULL(ptp_data->clock))
   652                  return;
   653
 > 654          ptp_cancel_worker_sync(ptp_data->clock);
   655          skb_queue_purge(&ptp_data->skb_rxtstamp_queue);
   656          ptp_clock_unregister(ptp_data->clock);
   657          ptp_data->clock = NULL;
   658  }
   659

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Will send out a v2.

Sorry,
-Vladimir