Thread (18 messages) 18 messages, 2 authors, 2020-01-20

Re: [PATCH net-next 4/4] udp: Support UDP fraglist GRO/GSO.

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2019-12-19 08:26:06

On Wed, Dec 18, 2019 at 11:03:09AM -0500, Willem de Bruijn wrote:
On Wed, Dec 18, 2019 at 8:35 AM Steffen Klassert
[off-list ref] wrote:
quoted
@@ -544,6 +585,18 @@ INDIRECT_CALLABLE_SCOPE int udp4_gro_complete(struct sk_buff *skb, int nhoff)
        const struct iphdr *iph = ip_hdr(skb);
        struct udphdr *uh = (struct udphdr *)(skb->data + nhoff);

+       if (NAPI_GRO_CB(skb)->is_flist) {
+               uh->len = htons(skb->len - nhoff);
+
+               skb_shinfo(skb)->gso_type |= (SKB_GSO_FRAGLIST|SKB_GSO_UDP_L4);
+               skb_shinfo(skb)->gso_segs = NAPI_GRO_CB(skb)->count;
+
+               skb->ip_summed = CHECKSUM_UNNECESSARY;
+               skb->csum_level = ~0;
why is this needed for ipv4 only?
It is needed for IPv6 too, I've just forgot to add it there.

Thanks for the review!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help