Thread (2 messages) flat view 2 messages, 2 authors, 2019-11-22

Re: [PATCH bpf-next] libbpf: fix bpf_object name determination for bpf_object__open_file()

From: Alexei Starovoitov <hidden>
Date: 2019-11-22 07:21:06
Also in: bpf

On Thu, Nov 21, 2019 at 4:36 PM Andrii Nakryiko [off-list ref] wrote:
If bpf_object__open_file() gets path like "some/dir/obj.o", it should derive
BPF object's name as "obj" (unless overriden through opts->object_name).
Instead, due to using `path` as a fallback value for opts->obj_name, path is
used as is for object name, so for above example BPF object's name will be
verbatim "some/dir/obj", which leads to all sorts of troubles, especially when
internal maps are concern (they are using up to 8 characters of object name).
Fix that by ensuring object_name stays NULL, unless overriden.

Fixes: 291ee02b5e40 ("libbpf: Refactor bpf_object__open APIs to use common opts")
Signed-off-by: Andrii Nakryiko <redacted>
Applied to bpf-next. Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help