Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2019-11-24 10:52:16
Also in:
lkml
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2019-11-24 10:52:16
Also in:
lkml
On Sat, Nov 23, 2019 at 08:33:40PM -0200, Julio Faracco wrote:
quoted
netdev: pass the stuck queue to the timeout handler This allows incrementing the correct timeout statistic without any mess. Down the road, devices can learn to reset just the specific queue. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- Warning: untested.Question... Wouldn't be better to create a module parameter instead change the function scope?
Passing the value in a global variable? That fails to be reentrant ...
I'm asking it because how many modules would effectively take advantage of it?
The cost is effectively 0 though. -- MST