Re: [PATCH 13/23] y2038: socket: remove timespec reference in timestamping

From
Arnd Bergmann <arnd@arndb.de>
Date
2019-11-11 20:25:12
Also in
lkml
Reply to
Arnd Bergmann, 2019-11-08
On Fri, Nov 8, 2019 at 10:15 PM Arnd Bergmann [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/uapi/linux/errqueue.h b/include/uapi/linux/errqueue.h
index 28491dac074b..0cca19670fd2 100644
--- a/include/uapi/linux/errqueue.h
+++ b/include/uapi/linux/errqueue.h
@@ -37,9 +37,16 @@ struct sock_extended_err {
  *     The timestamping interfaces SO_TIMESTAMPING, MSG_TSTAMP_*
  *     communicate network timestamps by passing this struct in a cmsg with
  *     recvmsg(). See Documentation/networking/timestamping.txt for details.
+ *     User space sees a timespec definition that matches either
+ *     __kernel_timespec or __kernel_old_timespec, in the kernel we
+ *     require two structure definitions to provide both.
  */
 struct scm_timestamping {
+#ifdef __KERNEL__
+       struct __kernel_old_timespec ts[3];
+#else
        struct timespec ts[3];
+#endif
 };
The kbuild bot pointed out that the way I sent this series, the use of
__kernel_old_timespec
causes a build failure, because I introduce this in a separate submission. I'm
moving this patch over to the other series, and changing the subject to

y2038: socket: use __kernel_old_timespec instead of timespec

With the expectation of merging it along with the other core patches.

      Arnd
Thread (8 messages) 8 messages, 4 authors, last reply 2019-11-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help