On 2019/11/2 上午4:11, Parav Pandit wrote:

quoted

-----Original Message-----
From: Jason Wang <jasowang@redhat.com>
Sent: Wednesday, October 30, 2019 1:45 AM
To: kvm@vger.kernel.org; linux-s390@vger.kernel.org; linux-
kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; intel-
gfx@lists.freedesktop.org; intel-gvt-dev@lists.freedesktop.org;
kwankhede@nvidia.com; alex.williamson@redhat.com; mst@redhat.com;
tiwei.bie@intel.com
Cc: virtualization@lists.linux-foundation.org; netdev@vger.kernel.org;
cohuck@redhat.com; maxime.coquelin@redhat.com;
cunming.liang@intel.com; zhihong.wang@intel.com;
rob.miller@broadcom.com; xiao.w.wang@intel.com;
haotian.wang@sifive.com; zhenyuw@linux.intel.com; zhi.a.wang@intel.com;
jani.nikula@linux.intel.com; joonas.lahtinen@linux.intel.com;
rodrigo.vivi@intel.com; airlied@linux.ie; daniel@ffwll.ch;
farman@linux.ibm.com; pasic@linux.ibm.com; sebott@linux.ibm.com;
oberpar@linux.ibm.com; heiko.carstens@de.ibm.com; gor@linux.ibm.com;
borntraeger@de.ibm.com; akrowiak@linux.ibm.com; freude@linux.ibm.com;
lingshan.zhu@intel.com; Ido Shamay [off-list ref];
eperezma@redhat.com; lulu@redhat.com; Parav Pandit
[off-list ref]; christophe.de.dinechin@gmail.com;
kevin.tian@intel.com; stefanha@redhat.com; Jason Wang
[off-list ref]
Subject: [PATCH V6 3/6] mdev: introduce device specific ops

Currently, except for the create and remove, the rest of mdev_parent_ops is
designed for vfio-mdev driver only and may not help for kernel mdev driver.
With the help of class id, this patch introduces device specific callbacks inside
mdev_device structure. This allows different set of callback to be used by vfio-
mdev and virtio-mdev.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---

[ ..]

quoted

diff --git a/include/linux/vfio_mdev_ops.h b/include/linux/vfio_mdev_ops.h
new file mode 100644 index 000000000000..3907c5371c2b
--- /dev/null
+++ b/include/linux/vfio_mdev_ops.h

@@ -0,0 +1,52 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * VFIO Mediated device definition
+ */
+
+#ifndef VFIO_MDEV_H
+#define VFIO_MDEV_H
+

I should have noticed this before. :-(
APIs exposed are by the mdev module and named with mdev_ prefix.
And file name is _ops.h,

We should name this file as mdev_vfio_ops.h

And #define should be MDEV_VFIO_OPS_H

quoted

+#include <linux/mdev.h>
+
+/**
+ * struct vfio_mdev_device_ops - Structure to be registered for each

s/vfio_mdev_device_ops/mdev_vfio_device_ops/

Similarly for virtio in future patches.

Will fix in V7.

  static void mtty_device_release(struct device *dev)
--
2.19.1
With above small nit changes to rename the fields and file,

Reviewed-by: Parav Pandit <redacted>

Appreciate that, thanks.