Thread (3 messages) read the whole thread 3 messages, 3 authors, 2019-11-06

Re: [PATCH net-next] net: dsa: Fix use after free in dsa_switch_remove()

From: Vivien Didelot <hidden>
Date: 2019-11-03 03:53:55
Also in: lkml

On Sat,  2 Nov 2019 20:13:26 -0700, Florian Fainelli [off-list ref] wrote:
The order in which the ports are deleted from the list and freed and the
call to dsa_tree_remove_switch() is done is reversed, which leads to an
s/dsa_tree_remove_switch/dsa_switch_remove/
use after free condition. Reverse the two: first tear down the ports and
switch from the fabric, then free the ports associated with that switch
fabric.

Fixes: 05f294a85235 ("net: dsa: allocate ports on touch")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks for reporting and fixing this!

Reviewed-by: Vivien Didelot <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help