RE: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

-----Original Message-----
From: Christophe Leroy <redacted>
Sent: Friday, November 1, 2019 11:30 AM
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>; Qiang Zhao
[off-list ref]; Leo Li [off-list ref]
Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org;
linux-kernel@vger.kernel.org; Scott Wood [off-list ref];
netdev@vger.kernel.org
Subject: Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly
depend on PPC32



Le 01/11/2019 à 13:42, Rasmus Villemoes a écrit :

quoted

Currently, FSL_UCC_HDLC depends on QUICC_ENGINE, which in turn

depends

quoted

on PPC32. As preparation for removing the latter and thus allowing the
core QE code to be built for other architectures, make FSL_UCC_HDLC
explicitly depend on PPC32.

Is that really powerpc specific ? Can't the ARM QE perform HDLC on UCC ?

No.  Actually the HDLC and TDM are the major reason to integrate a QE on the ARM based Layerscape SoCs.

Since Rasmus doesn't have the hardware to test this feature Qiang Zhao probably can help verify the functionality of TDM and we can drop this patch.

Regards,
Leo

Christophe

quoted

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
  drivers/net/wan/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig index

dd1a147f2971..78785d790bcc 100644

--- a/drivers/net/wan/Kconfig
+++ b/drivers/net/wan/Kconfig

@@ -270,7 +270,7 @@ config FARSYNC
  config FSL_UCC_HDLC
  	tristate "Freescale QUICC Engine HDLC support"
  	depends on HDLC
-	depends on QUICC_ENGINE
+	depends on QUICC_ENGINE && PPC32
  	help
  	  Driver for Freescale QUICC Engine HDLC controller. The driver
  	  supports HDLC in NMSI and TDM mode.