Re: [PATCH net 1/2] openvswitch: drop unneeded BUG_ON() in ovs_flow_cmd_build_info()
From: Sergei Shtylyov <hidden>
Date: 2019-11-27 10:08:01
Hello! On 26.11.2019 15:10, Paolo Abeni wrote:
All callers already deal with errors correctly, dump a warn instead.
Warning, maybe?
quoted hunk ↗ jump to hunk
Fixes: ccb1352e76cf ("net: Add Open vSwitch kernel components.") Signed-off-by: Paolo Abeni <pabeni@redhat.com> --- net/openvswitch/datapath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index d8c364d637b1..e94f675794f1 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c@@ -882,7 +882,7 @@ static struct sk_buff *ovs_flow_cmd_build_info(const struct sw_flow *flow, retval = ovs_flow_cmd_fill_info(flow, dp_ifindex, skb, info->snd_portid, info->snd_seq, 0, cmd, ufid_flags); - BUG_ON(retval < 0); + WARN_ON_ONCE(retval < 0); return skb; }
MBR, Sergei