Re: [PATCH v2 net-next] Enhanced skb_mpls_pop to update ethertype of the packet in all the cases when an ethernet header is present is the packet.

On Mon, 25 Nov 2019 16:32:34 +0530, Martin Varghese wrote:

quoted

quoted

Changes in v2:
    - check for dev type removed while updating ethertype
      in function skb_mpls_pop.
    - key->mac_proto is checked in function pop_mpls to pass
      ethernt flag to skb_mpls_pop.
    - dev type is checked in function tcf_mpls_act to pass
      ethernet flag to skb_mpls_pop.  

nit: changelog can be kept in the commit message for netdev patches
 

Multiple versions are mostly due to coding error.do you insist to keep
the change log in commit message ?

Not really, just a minor suggestion.