Re: [PATCH bpf-next v3 1/2] xsk: store struct xdp_sock as a flexible array member of the XSKMAP

On Mon, 28 Oct 2019 at 19:01, Jakub Kicinski
[off-list ref] wrote:

On Fri, 25 Oct 2019 11:32:18 +0200, Björn Töpel wrote:

quoted

From: Björn Töpel <redacted>

Prior this commit, the array storing XDP socket instances were stored
in a separate allocated array of the XSKMAP. Now, we store the sockets
as a flexible array member in a similar fashion as the arraymap. Doing
so, we do less pointer chasing in the lookup.

Signed-off-by: Björn Töpel <redacted>

Damn, looks like I managed to reply to v2.

No worries! Thanks for taking a second look.

I think the size maths may overflow on 32bit machines on the addition.

Ugh, right. Re-reading the older threads. Thanks for pointing this
out!I'll get back with a v4.


Björn