Thread (2 messages) 2 messages, 2 authors, 2019-10-31

Re: [PATCH] batman-adv: Simplify 'batadv_v_ogm_aggr_list_free()'

From: Sven Eckelmann <sven@narfation.org>
Date: 2019-10-31 08:00:30
Also in: batman, kernel-janitors, lkml

On Thursday, 31 October 2019 08:42:55 CET Christophe JAILLET wrote:
Use 'skb_queue_purge()' instead of re-implementing it.

Signed-off-by: Christophe JAILLET <redacted>
Consider this patch applied. I just have to leave now and thus I will only 
apply after my return.
---
BTW, I don't really see the need of 'aggr_list_lock'. I think that the code
could be refactored to drop 'aggr_list_lock' and use the already existing
'aggr_list.lock'.
This would require to use the lock-free __skb_... variants when working on
'aggr_list'.

As far as I understand, the use of 'aggr_list' and 'aggr_list_lock' is
limited to bat_v_ogm.c'. So the impact would be limited.
This would avoid a useless locking that never fails, so the performance
gain should be really limited.

So, I'm not sure this would be more readable and/or future proof, so
I just note it here to open the discussion.

If interested, I have a (compiled tested only) patch that implements this
change.
Yes, please send it over.

Kind regards,
	Sven

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help