Thread (2 messages) 2 messages, 2 authors, 2019-10-28

Re: [PATCH] cfg80211: Fix memory leak in cfg80211_inform_single_bss_frame_data

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2019-10-28 12:13:04
Also in: linux-wireless, lkml

On Sun, 2019-10-27 at 13:15 -0500, Navid Emamdoost wrote:
In the implementation of cfg80211_inform_single_bss_frame_data() the
allocated memory for ies is leaked in case of an error. Release ies if
cfg80211_bss_update() fails.
I'm pretty sure it's more complicated than this patch (and the previous
one) - we already do free this at least in the case that "new =
kzalloc(...)" fails in cfg80211_bss_update().

Your Fixes: tag is also wrong, back then we didn't even have the dynamic
allocation of the IEs.

I'm dropping this patch and the other and will make a note to eventually
look at the lifetime issue here you point out, but if you want to work
on it instead let me know.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help