Thread (7 messages) flat view 7 messages, 3 authors, 2019-11-05

Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling generic_handle_irq()

From: Stefan Wahren <wahrenst@gmx.net>
Date: 2019-10-27 12:15:11
Also in: linux-usb, lkml

Hi Daniel,

Am 25.10.19 um 10:04 schrieb Daniel Wagner:
...

Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")
Cc: Woojung Huh <woojung.huh@microchip.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Stefan Wahren <wahrenst@gmx.net>
Cc: Jisheng Zhang <redacted>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <redacted>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Daniel Wagner <redacted>
---

Hi,

This patch just fixes the warning. There are still problems left (the
unstable NFS report from me) but I suggest to look at this
separately. The initial patch to revert all the irqdomain code might
just hide the problem. At this point I don't know what's going on so I
rather go baby steps. The revert is still possible if nothing else
works.
did you ever see this pseudo lan78xx-irqs fire? I examined
/proc/interrupts on RPi 3B+ and always saw a 0.

FWIW you can have:

Tested-by: Stefan Wahren <wahrenst@gmx.net>

for this patch.

Regards
Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help