Re: [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling

From
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date
2019-10-25 07:36:50
Also in
linux-rt-users, linux-usb, lkml
Reply to
David Miller, 2019-10-24
On 2019-10-24 14:57:16 [-0700], David Miller wrote:
From: Daniel Wagner <redacted>
Date: Fri, 18 Oct 2019 10:28:17 +0200
quoted
handle_simple_irq() expect interrupts to be disabled. The USB
framework is using threaded interrupts, which implies that interrupts
are re-enabled as soon as it has run.
 ...

Where are we with this patch?  I'm tossing it.

It seems Sebastian made a suggestion, someone else said his suggestion
should be tried, then everything died.

Please follow up and post when something is ready.
My suggestion with the nested-handler was nonsense. The suggestion with
the local_irq_disable() before invoking generic_handle_irq() did avoid
the warning but the NFS-root was not stable (and Daniel reported a lot
of USB interrupts coming which indicates that the interrupt-handler is
not acknowledging the interrupt properly).

It works by reverting the IRQ-domain code as this patch does. "Works" as
in "no warnings" and "NFS-root looks stable".

You have two ACKs on that patch. I could ask Daniel to repost the patch
with additional informations.
My last information from Daniel was that the rpi tree works and I'm not
sure if he is looking for the missing ingredient or preferring the
removal of the non-working code.

Sebastian
Thread (15 messages) 15 messages, 6 authors, last reply 2019-10-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help